-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add raylib support #235
base: master
Are you sure you want to change the base?
add raylib support #235
Conversation
is it only about |
No it's about application design and how to extend vab without building special case support into the app for every framework available out there. A compile time plugin system would be gold - but maybe runtime plugin support would be okay as well. vab also miss some essential features from the v_sdl4android project. |
... but yes, the failing CI check is because the files need to be formatted with |
src_path := os.join_path(raylib_path, 'src') | ||
ndk_path := ndk.root() | ||
os.execute('make -C ${src_path} clean') | ||
arch_name := if arch == 'arm64-v8a' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be more eficient and nicer with mach{...}
instead of if ... else if ... else
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would look cleaner with match
. The else
branch for the match would take care of the following if
as well.
|
||
// add the compiled raylib libraries for each arch | ||
if is_raylib { | ||
build_cmd << '-L ${lflags}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe initialisation of 'lflags' for raylib would be nice put inside if
Just to refresh what is going on here: I'm keeping this PR open because I think Work has been done lately to simplify calling and using |
No description provided.