map: fix map.clone, refactor, fix map_get_1, map_set_1 non-string keys #7538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix map.clone to clone keys too. Move DenseArray.clone_key to map method as it will need key metadata. Change DenseArray.push to only make space, not clone key. Don't assume string key for map_get_1, map_set_1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split out some work from #7503 in case it is decided not to merge it. It was already reviewed there.
Fix map.clone to clone keys too.
Move DenseArray.clone_key to map method as it will need key metadata for non-string keys.
Change DenseArray.push to only make space, not clone key.
Don't assume string key for map_get_1, map_set_1.