map: make DenseArray::has_index not assume string keys #7284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add separate `is_deleted` array - this is only allocated the first time a key is deleted. Also set array cap in test.
ntrel
commented
Dec 12, 2020
| @@ -484,7 +497,6 @@ pub fn (mut m map) delete(key string) { | |||
| if m.key_values.deletes >= (m.key_values.len >> 1) { | |||
| m.key_values.zeros_to_end() | |||
| m.rehash() | |||
| m.key_values.deletes = 0 | |||
There was a problem hiding this comment.
Note: zeros_to_end already does this, so this was redundant.
spytheman
reviewed
Dec 12, 2020
|
LGTM, but I think we need better tests (fuzzing) to ensure that we are not introducing bugs. We need something like https://github.com/ka-weihe/hashmap-v/blob/master/monkeytest.v, but better. I used to run that for multiple hours in multiple threads with |
ka-weihe
approved these changes
Dec 12, 2020
Merged
|
@ka-weihe OK, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6991.
Add separate
is_deletedarray - this is only allocated the first time a key is deleted. This is allocated separately from thedataarray for better performance when there are no deleted elements (a common case).Also set array
capin test.