map: use untyped keys for DenseArray and interleave keys and values #7142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use int instead of u32 for len, cap (less casting). Assume string key for has_index(). Remove unused DenseArray::get().
Somewhere voidptr arithmetic is happening. I'm going to file a checker bug about not allowing it. Most compilers treat it as byteptr, but not MSVC. I tracked down three of these but the last one is elusive. I'd rather not install MSVC and there doesn't seem to be an easy way to get V to generate v.c for it without it installed. Update: found it, and I've implemented the checker error locally. I'll submit it Monday. |
|
I'm guessing gitly error is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6991.
Use int instead of u32 for len, cap (less casting, consistent with
array).Still assume string key in has_index() for now (next pull will fix this). Everywhere else in DenseArray keys are now untyped.
Remove unused DenseArray::get().