Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgen: fix codegen for sumtype casting on selector on as cast with field non ptr #23391

Merged
merged 2 commits into from
Jan 6, 2025
Merged

cgen: fix codegen for sumtype casting on selector on as cast with field non ptr #23391

merged 2 commits into from
Jan 6, 2025

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Jan 6, 2025 •
edited by huly-for-github bot
Loading

spytheman
spytheman approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@felipensp felipensp marked this pull request as ready for review January 6, 2025 14:26
@spytheman spytheman merged commit 0c9d076 into vlang:master Jan 6, 2025
72 checks passed
@felipensp felipensp deleted the fix_selector_as_cast branch January 8, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C compilation error: cannot convert 'struct v__ast__Expr' to 'struct v__ast__Expr *'
2 participants
@felipensp @spytheman