Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stbi: update thirdparty/stb_image to latest commit ae721c5 #21127

Merged
merged 5 commits into from
Apr 1, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 28, 2024

Update stbi to latest commit https://github.com/nothings/stb/tree/ae721c50eaf761660b4f90cc590453cdb0c2acd0.

Vab currently misses a cflag for andorid compilation to work.
Instead of making it a requirement to add it manually when compiling or running CI, this PR to adds it directly into vab: vlang/vab#278.

Tested on a fork with a temporary change to use the vab fork of the linked PR above

# vab_ci.yml
# ...
# Line 28
      - name: Install vab
        run: |
-         .github/workflows/retry.sh v install vab
+         .github/workflows/retry.sh v install https://github.com/ttytm/vab@update-stbi-cflags

Result: https://github.com/ttytm/v/actions/runs/8469154352

So the only requirement should be merging vlang/vab#278 then re-running the full VAB workflow should be green.

@ttytm ttytm marked this pull request as draft March 28, 2024 03:46
@ttytm ttytm changed the title stbi: update thirdparty/stb_image to latest version stbi: update thirdparty/stb_image to latest commit [nothings/stb@ae721c5](https://github.com/nothings/stb/tree/ae721c50eaf761660b4f90cc590453cdb0c2acd0) Mar 28, 2024
@ttytm ttytm changed the title stbi: update thirdparty/stb_image to latest commit [nothings/stb@ae721c5](https://github.com/nothings/stb/tree/ae721c50eaf761660b4f90cc590453cdb0c2acd0) stbi: update thirdparty/stb_image to latest commit ae721c5 Mar 28, 2024
@ttytm ttytm marked this pull request as ready for review March 28, 2024 15:00
@ttytm ttytm requested a review from spytheman April 1, 2024 05:07
@spytheman spytheman merged commit 97e1b24 into vlang:master Apr 1, 2024
41 checks passed
@ttytm ttytm deleted the stib/update-thirdparty branch April 1, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants