Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compilation errors V 0.4 fix #256

Closed
wants to merge 5 commits into from
Closed

compilation errors V 0.4 fix #256

wants to merge 5 commits into from

Conversation

sibkod
Copy link

@sibkod sibkod commented Aug 15, 2023

godalming123
godalming123 reviewed Oct 13, 2023
View reviewed changes
Copy link

@godalming123 godalming123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this, I just looked at the code. Surely, the lack of whitespace isn't a V thing it looks awful.

src/feed_service.v Outdated Show resolved Hide resolved
src/feed_service.v Outdated Show resolved Hide resolved
src/user_service.v Outdated Show resolved Hide resolved
@JalonSolov
Copy link
Contributor

Running v fmt -w would correct those.

@ttytm
Copy link
Member

ttytm commented Oct 13, 2023

Well, it's formatted and will build on regular ubuntu in ci now. But it won't connect to the localhost it serves on. Not a ci issue but the same locally with current gitly.

@sibkod sibkod closed this by deleting the head repository Oct 23, 2023
@godalming123
Copy link

Why was this PR closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godalming123 godalming123 godalming123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sibkod @JalonSolov @ttytm @godalming123