Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testing with the multi-binary platform independent #181

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

syrmel
Copy link
Member

@syrmel syrmel commented Nov 29, 2024

Up to now, the testing logic was that if we test in Windows, the multi-binary gets used, otherwise it's the individual command line utils. Disentangling platform and multi-binary use creates flexibility to the future, such as:

  • set up tests with the multi-binary on *nix
  • use other versions of Windows coreutils (like GNU instead of the current Rust version from uutils) to test against

... and the code is a little cleaner with fewer $if !windows :)

@JalonSolov JalonSolov merged commit e975b67 into vlang:main Nov 29, 2024
4 checks passed
@syrmel syrmel deleted the testing branch November 29, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants