feat: implement sum #121
Merged
feat: implement sum #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: implement buffered read for BSD algorithm feat: implement buffered read for SysV algorithm ref: extract block count fns chore: clean uo todo feat: add tests ref: split printing and data collect feat: add sysv quirk tests feat: add rjust fn test: add bsd main behanior tests feat: add zero padding to BSD sum, add tests feat: wide block count col
|
Close/re-open to force CI to re-run. |
|
wc and wc_test.v have been reformatted and updated to compile cleanly with latest V, so they can be removed from this PR. |
spytheman
force-pushed
the
igrekus/implement-sum
branch
from
90c810d to
df4d8b0
Compare
|
(rebase over current main) |
spytheman
reviewed
Apr 7, 2024
|
Close/re-open to force CI to re-run. |
igrekus
force-pushed
the
igrekus/implement-sum
branch
from
7148d2b to
db1579a
Compare
Can't use echo in Windows as it produces different outputs; example: `echo hhh | od -t x1` Linux 0000000 68 68 68 0a 0000004 Windows 0000000 68 68 68 20 0d 0a 0000006
Avoid `echo` because it behaves differently in Windows
Windows emits new lines as \r\n but the reference result was calculated on *nix where it was only \n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
sumcommand, add tests.