New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning from clang on testing function return. #28

Open

scott-snyder wants to merge 1 commit into vitillo:master from scott-snyder:clangwarn2-20240103

Commits on Jan 3, 2024

Fix warning from clang on testing function return.

m_socket->send() returns a bool, but code in ServerSocket.cpp compares
it against -1.  clang16 generates a warning that this comparision
is never true.

Apparently this is written this way because the library used to return
an int here, but now signals errors by raising an exception.
Avoid the warning by casting to an int.

scott snyder committed Jan 3, 2024