-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(env-replacer): don't modify string literals #1943
fix(env-replacer): don't modify string literals #1943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case for this?
Sure. I don't see any plugin-specific tests in |
You can add a new test that contains |
I think we have |
The
|
You can ignore the Cypress error for now |
The Windows test failure is unrelated to my changes, as it's also happening on the I get a different test failure locally. Looks like a snapshot needs to be updated:
After hitting |
* fix(env-replacer): don't modify string literals fix vitest-dev#1941 * test(env-replacer): verify string literals are ignored * chore: fix typo envRelacer.ts -> envReplacer.ts * chore: fix typo envRelacer.ts -> envReplacer.ts * chore: move strip-literal to correct package
fix #1941