-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replacing compression with modern version #6557
fix: replacing compression with modern version #6557
Conversation
added |
Btw can you check |
@Niputi in the PR developit mentions a fix in the inlined version of WMR of it that wasn't backported. Did you check what that was about? lukeed/polka#148 (comment) |
I can see a few differences when comparing this to https://github.com/preactjs/wmr/pull/155/files |
@Niputi maybe you could directly copy the current version from WMR adding their license in it: https://github.com/preactjs/wmr/blob/main/packages/wmr/src/lib/polkompress.js There are other changes it seems compared to the one in your last comment. |
30cb9d6
to
82b3c99
Compare
@patak-dev is this change good? |
I think it is good @Niputi, thanks for updating it! Let's wait for the next minor for it so we more testing. I think we should stop merging new changes until we release 2.8. We should start 2.9 rather soon and avoid being one month again in beta |
@Niputi would you resolve the conflicts so we merge this PR? Thanks! |
b85294d
to
1e45e37
Compare
done @patak-dev |
Description
correctly fix: #2754
once lukeed/polka#148 have merged and released as a polka package, we can use their package instead.
code is copied and slightly modified from the pull request
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).