fix: try parse server.origin URL
#19241
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
approved these changes
Jan 20, 2025
7 tasks
dominikg
reviewed
Jan 20, 2025
| try { | ||
| const serverOriginUrl = new URL(resolvedServerOptions.origin) | ||
| list.push(serverOriginUrl.hostname) | ||
| } catch {} |
There was a problem hiding this comment.
should this have a debug log at least? quiet swallowing can lead to long and frustrating debug sessions
There was a problem hiding this comment.
we can add one, yes, but I don't expect that this fix will stay in place
patak-dev
pushed a commit
that referenced
this pull request
Jan 20, 2025
patak-dev
pushed a commit
that referenced
this pull request
Jan 20, 2025
|
We really appreciate the Vite team making this consideration for the Laravel community. We have a PR up to make our placeholder URL a well-formed URL, which should mean this check can be removed and our plugin will continue to work. Thank you again for supporting our community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #19239
This line is causing the latest version to fail: https://github.com/laravel/vite-plugin/blob/e57a940c22f90e72002380d3dad1a2c6f1921983/src/index.ts#L154
I don't think we really expect frameworks to configure the option this way, but they have an interesting usecase that indeed make it seem like we could improve the
server.originoption a bit, but maybe later in the future.