Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have color picker bind to $("html") for mousemove/up #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

collin
Copy link

@collin collin commented Feb 3, 2012

This way a drag initiated inside the canvas still work when you end up
going "outside" the lines of the color picker. Otherwise it can be tedious to
get to the very edge of the color picker.

This way a drag initiated inside the canvas still work when you end up
going "outside" the lines of the color picker. Otherwise it can be tedious to
get to the very edge of the color picker.
@tj
Copy link
Member

tj commented Feb 3, 2012

we should add some bounds checking too since it kinda goes wonky if you drag out, it would be a lot nicer if we lock it in the rect

@collin
Copy link
Author

collin commented Feb 3, 2012

Yes, maybe use Math.min and Math.max in the update function to keep things inside the canvas? Or is there a better place to put it?

@tj
Copy link
Member

tj commented Feb 3, 2012

yup that should be fine

@tj tj mentioned this pull request Feb 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants