-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json, npm and browserify support #70
Conversation
added both of you! LMK what the npm usernames are |
package.json, npm and browserify support
@shuvalov-anton could you publish, I do not have time available until the weekend. Thanks! |
@tj thank you :D |
apparently I dont have access to the npm module either |
@axelpale both |
@shuvalov-anton I would prefer |
Btw, I removed false npm installation instructions from Readme.md that got there in this PR. After ... With npm:
... |
@axelpale nice. |
@shuvalov-anton Now it is published \o/ |
This pull request solves issue/41, issue/42 and issue/71, the first two relating to missing package.json, missing npm entry and therefore missing browserify support. The issue/41 has many details about the issue and its solution. After the merge, move.js can be downloaded via npm and used with browserify but still continued to be used with component(1) just as before.
After merge, one more thing is required by you, precious collaborator:
npm publish
This pull request includes
require('emitter')
byrequire('component-emitter')
and similar as discussed in issue/41, providing compatibility for both component(1) and node/commonjs/browserify.remotes
from component.json because the public component must not contain any remotes. Ifremotes
exists, runningcomponent install
produces errorno remote found for dependency ...
.make move.js
andmake move.min.js
. Apparently a few extra kilobytes were shaved off as well (28 kB -> 26 kB and 16 kB -> 14 kB).