Path generation #82
Open
Path generation #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will be properly bound if it is used in the handler - Not supported for the case where the handler is an object which maps format name strings to handler functions
- One path for creating new resources - One path for editing existing resources - One path for the "root/collection" path that is routed to index - One path for accessing specific records, can be used with DELETE, PUT - Only creates paths without hostnames for the moment
|
Ah crap, I forgot that I already merged the bind handler branch into my own master before checking out this branch... Well if that would get merged first it wouldn't be a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that URL generation has been added as an issue like 2 years ago and there's even an orphaned pull request for it.
The pull request seems to be made for an older version so I made a new pull request based on the latest master. Technically this is all about path generation so far, not URL generation, but I keep using them interchangeably even if I try not to.
When calling add I'm adding a reference to the parent resource and then we can recursively create urls by referring to the parent's recordPath.
The test cases show how the methods can be used.