Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert-BlockString: Allow string array and single string for Expected #3

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Aug 22, 2024

Pull Request (PR) description

  • Assert-BlockString
    • Allow it to pass string array and single string to Expected parameter.

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md and source/WikiSource.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where applicable). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju merged commit 7f7f39b into viscalyx:main Aug 22, 2024
10 checks passed
@johlju johlju deleted the fix/assert branch August 22, 2024 19:07
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (9d3a7eb) to head (d441c24).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@        Coverage Diff         @@
##           main    #3   +/-   ##
==================================
+ Coverage    75%   78%   +3%     
==================================
  Files         2     2           
  Lines        20    23    +3     
==================================
+ Hits         15    18    +3     
  Misses        5     5           
Flag Coverage Δ
unit 78% <100%> (+3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
source/Public/Assert-BlockString.ps1 100% <100%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant