Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Adding Measurement functionality to library #110

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

DGonzalezVillal
Copy link
Member

Adding structures and functions to be able to calculate expected guest measurements.

Copy link
Contributor

@larrydewey larrydewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some excellent work! There are some changes which I would like to discuss with you, but this is looking great!

src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/measurement/gctx.rs Outdated Show resolved Hide resolved
src/measurement/sev_hashes.rs Show resolved Hide resolved
src/measurement/sev_hashes.rs Outdated Show resolved Hide resolved
src/measurement/vcpu_types.rs Outdated Show resolved Hide resolved
src/measurement/vmsa.rs Outdated Show resolved Hide resolved
src/measurement/vmsa.rs Show resolved Hide resolved
src/error.rs Show resolved Hide resolved
src/error.rs Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/measurement/gctx.rs Outdated Show resolved Hide resolved
src/measurement/measurement_functions.rs Outdated Show resolved Hide resolved
src/measurement/gctx.rs Outdated Show resolved Hide resolved
src/measurement/measurement_functions.rs Outdated Show resolved Hide resolved
larrydewey

This comment was marked as resolved.

@larrydewey larrydewey self-requested a review October 31, 2023 14:18
larrydewey
larrydewey previously approved these changes Oct 31, 2023
Copy link
Contributor

@larrydewey larrydewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore Outdated Show resolved Hide resolved
src/measurement/mod.rs Outdated Show resolved Hide resolved
src/measurement/ovmf.rs Outdated Show resolved Hide resolved
src/measurement/ovmf.rs Outdated Show resolved Hide resolved
src/measurement/ovmf.rs Show resolved Hide resolved
src/measurement/vcpu_types.rs Outdated Show resolved Hide resolved
src/measurement/vmsa.rs Outdated Show resolved Hide resolved
src/measurement/vmsa.rs Outdated Show resolved Hide resolved
tests/measurement.rs Outdated Show resolved Hide resolved
tests/measurement.rs Outdated Show resolved Hide resolved
@larrydewey larrydewey force-pushed the main branch 2 times, most recently from 72dcbbc to b381f27 Compare November 4, 2023 03:30
Copy link
Contributor

@larrydewey larrydewey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylerfanelli tylerfanelli merged commit 2a9bbb5 into virtee:main Nov 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants