Build the C API with meson rather than cargo-c #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerfanelli
force-pushed
the
meson
branch
6 times, most recently
from
24a058f to
66d4ffd
Compare
The unsigned int type seems more reasonable, as the size of the attestation report should fit in 4 bytes. Signed-off-by: Tyler Fanelli <[email protected]>
Rather than using cargo-c and building with pkg-config, we can directly incorporate the meson build system to build the library's C API. In doing this, projects using meson will be able to "wrap" the library and directly link with their projects. Signed-off-by: Tyler Fanelli <[email protected]>
larrydewey
requested changes
Oct 10, 2023
|
Also, there are some linting errors which need to be patched. |
tylerfanelli
force-pushed
the
meson
branch
2 times, most recently
from
90137fa to
11d0a83
Compare
The SEV launch C APIs use the launch::sev module, which requires the sev feature enabled. Signed-off-by: Tyler Fanelli <[email protected]>
|
@larrydewey Can you re-review? |
larrydewey
approved these changes
Oct 26, 2023
cschramm
reviewed
Feb 23, 2024
| @@ -21,13 +21,18 @@ maintenance = { status = "actively-developed" } | |||
| is-it-maintained-issue-resolution = { repository = "virtee/sev" } | |||
| is-it-maintained-open-issues = { repository = "virtee/sev" } | |||
|
|
|||
| [lib] | |||
| crate-type = ["staticlib", "dylib", "rlib"] | |||
There was a problem hiding this comment.
What's the idea of dylib here? Unfortunately it breaks builds with panic="abort".
There was a problem hiding this comment.
Good point, dylib is really for macOS which isn't really a concern here. I think it's safe to remove this. @larrydewey do you agree?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
cargo-cand building withpkg-config, we can directly incorporate the meson build system to build the library's C API. In doing this, projects usingmesonwill be able to "wrap" the library and directly link with their projects.