Blockchain rpcs #323
Draft
Blockchain rpcs #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we already use axum for the metrics crate, and the currently used crate is unmaintained. This commit re-implements the json-rpc using axum. Once nice side-effect is that if we ever want to use another encode or websockets, axum already supports that.
If we do all rpcs inside `server.rs` it'll grow and become a huge file, this commit creates a blockchain module where we define all blockchain-related rpcs as defined by core[1] docs. [1]: https://bitcoincore.org/en/doc/28.0.0/rpc
This commit implements some very basic rpcs from bitcoin core that can be implmented without much changes inside floresta itself. Only blockchain rpcs were implemented here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #322
This is the first step towards a core-compatible(ish) json rpc. This should help other applications to integrate with
florestadwithout requiring any additional work.List of things achieved here:
v28Things that we'll need to build next (not done here):
coreandflorestad, checks if they return the same. We should have one that does that against different versions of core, and one that runs every week or something like this, testing our master and theirs.