WIP(wire): add v2 transport #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting things rolling on BIP324 just to start a discussion. It will take some significant time for signet nodes to adopt this so it can actually be tested more thoroughly. In the meantime I am open for nits and nacks. I did a couple weird things like use a bunch of guard statements when trying the V2 connection instead of passing
Resultbecause I think the V2 connection should fail silently, as there is a lot that can go wrong and we should eagerly fall back to V1 instead of disconnecting. Writing V2 messages is not correct yet, as I need to add the correct message bytes.