Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript to the project #654

Merged
merged 7 commits into from
May 13, 2024
Merged

Add TypeScript to the project #654

merged 7 commits into from
May 13, 2024

Conversation

pamella
Copy link
Contributor

@pamella pamella commented May 10, 2024

Description

Motivation and Context

Related articles:

Screenshots (if appropriate):

Steps to reproduce (if appropriate):

  • The project should be working properly:
    • With docker
    • Without docker
    • Deployed (e.g.: Render)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires documentation updates.
  • I have updated the documentation accordingly.
  • My change requires dependencies updates.
  • I have updated the dependencies accordingly.

@pamella pamella force-pushed the feat/typescript branch from d4827f2 to 836be2b Compare May 10, 2024 22:10
Comment on lines +10 to +11
const dispatch: AppDispatch = useDispatch();
const restCheck = useSelector((state: RootState) => state.restCheck);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This will change once we get to work on the client generation.

@pamella pamella requested a review from fjsj May 13, 2024 12:22
.eslintrc.js Show resolved Hide resolved
frontend/js/store/index.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but please check comments.

Comment on lines +47 to +53
- id: tsc
name: tsc-local
entry: npm run tsc
language: system
types: [file]
files: \.(ts|tsx)$
pass_filenames: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual change.

@pamella pamella merged commit ccb3fe4 into main May 13, 2024
3 checks passed
@pamella pamella deleted the feat/typescript branch May 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants