Fix typos #2
Merged
Fix typos #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥳 🥳 🥳 🥳 🥳 |
vimpostor
added a commit
that referenced
this pull request
Nov 19, 2023
Otherwise we end up accepting an DnD drop event and starting our own DnD drag event in the same event loop iteration, which makes Qt crash: Thread 1 "blobdrop" received signal SIGSEGV, Segmentation fault. 0x00007ffff793fb8c in QQuickDeliveryAgentPrivate::deliverDragEvent(QQuickDragGrabber*, QEvent*) () from /usr/lib/libQt6Quick.so.6 (gdb) bt #0 0x00007ffff793fb8c in QQuickDeliveryAgentPrivate::deliverDragEvent(QQuickDragGrabber*, QEvent*) () at /usr/lib/libQt6Quick.so.6 #1 0x00007ffff7938a3b in QQuickDeliveryAgent::event(QEvent*) () at /usr/lib/libQt6Quick.so.6 #2 0x00007ffff78779a5 in QQuickWindow::event(QEvent*) () at /usr/lib/libQt6Quick.so.6 #3 0x00007ffff61626d8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/libQt6Core.so.6 #4 0x00007ffff6815448 in QWindowSystemInterface::handleDrop(QWindow*, QMimeData const*, QPoint const&, QFlags<Qt::DropAction>, QFlags<Qt::MouseButton>, QFlags<Qt::KeyboardModifier>) () at /usr/lib/libQt6Gui.so.6 #5 0x00007ffff1ac6960 in () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #6 0x00007ffff1abf5d2 in () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #7 0x00007ffff6b17eff in QBasicDrag::eventFilter(QObject*, QEvent*) () at /usr/lib/libQt6Gui.so.6 #8 0x00007ffff6160bd8 in QCoreApplicationPrivate::sendThroughApplicationEventFilters(QObject*, QEvent*) () at /usr/lib/libQt6Core.so.6 #9 0x00007ffff6160d96 in QCoreApplicationPrivate::notify_helper(QObject*, QEvent*) () at /usr/lib/libQt6Core.so.6 #10 0x00007ffff61626d8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/libQt6Core.so.6 #11 0x00007ffff67a5355 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () at /usr/lib/libQt6Gui.so.6 #12 0x00007ffff68105dc in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt6Gui.so.6 #13 0x00007ffff1a9998f in () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #14 0x00007ffff4dcaf69 in () at /usr/lib/libglib-2.0.so.0 #15 0x00007ffff4e29327 in () at /usr/lib/libglib-2.0.so.0 #16 0x00007ffff4dc9162 in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0 #17 0x00007ffff6397934 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt6Core.so.6 #18 0x00007ffff616cc5e in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt6Core.so.6 #19 0x00007ffff6b147da in QBasicDrag::drag(QDrag*) () at /usr/lib/libQt6Gui.so.6 #20 0x00007ffff6b16719 in QDragManager::drag(QDrag*) () at /usr/lib/libQt6Gui.so.6 #21 0x00007ffff6b1690e in QDrag::exec(QFlags<Qt::DropAction>) () at /usr/lib/libQt6Gui.so.6 #22 0x000055555559bab7 in Backend::drag_paths(std::vector<Path, std::allocator<Path> > const&) (this=0x5555555c5580 <Backend::get()::s>, paths=std::vector of length 1, capacity 1 = {...}) at src/backend.cpp:75 #23 0x000055555559c584 in Backend::exec_frontend(std::vector<Path, std::allocator<Path> > const&) (this=0x5555555c5580 <Backend::get()::s>, paths=std::vector of length 1, capacity 1 = {...}) at src/backend.cpp:136 #24 0x000055555559c88c in Backend::handle_dropped_urls(QList<QUrl> const&) (this=0x5555555c5580 <Backend::get()::s>, urls=...) at src/backend.cpp:165 #25 0x0000555555588fbc in Backend::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=0x5555555c5580 <Backend::get()::s>, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7fffffffa238) at build/blobdrop_autogen/UVLADIE3JM/moc_backend.cpp:164 #26 0x00005555555891c0 in Backend::qt_metacall(QMetaObject::Call, int, void**) (this=0x5555555c5580 <Backend::get()::s>, _c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7fffffffa238) at build/blobdrop_autogen/UVLADIE3JM/moc_backend.cpp:210 #27 0x00007ffff730bf64 in () at /usr/lib/libQt6Qml.so.6 #28 0x00007ffff71dc087 in () at /usr/lib/libQt6Qml.so.6 #29 0x00007ffff71e90b9 in QV4::QObjectMethod::callInternal(QV4::Value const*, QV4::Value const*, int) const () at /usr/lib/libQt6Qml.so.6 #30 0x00007ffff72298da in () at /usr/lib/libQt6Qml.so.6 #31 0x00007ffff722cf15 in () at /usr/lib/libQt6Qml.so.6 #32 0x00007ffff719e91e in () at /usr/lib/libQt6Qml.so.6 #33 0x00007ffff71a1c65 in QV4::Function::call(QObject*, void**, QMetaType const*, int, QV4::ExecutionContext*) () at /usr/lib/libQt6Qml.so.6 #34 0x00007ffff72d9917 in QQmlJavaScriptExpression::evaluate(void**, QMetaType const*, int) () at /usr/lib/libQt6Qml.so.6 #35 0x00007ffff7272a11 in QQmlBoundSignalExpression::evaluate(void**) () at /usr/lib/libQt6Qml.so.6 #36 0x00007ffff7277fbb in () at /usr/lib/libQt6Qml.so.6 #37 0x00007ffff72fa977 in QQmlNotifier::emitNotify(QQmlNotifierEndpoint*, void**) () at /usr/lib/libQt6Qml.so.6 #38 0x00007ffff61b988a in () at /usr/lib/libQt6Core.so.6 #39 0x00007ffff7a1e5ab in QQuickDropArea::dropEvent(QDropEvent*) () at /usr/lib/libQt6Quick.so.6 #40 0x00007ffff77d5d47 in QQuickItem::event(QEvent*) () at /usr/lib/libQt6Quick.so.6 #41 0x00007ffff61626d8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/libQt6Core.so.6 #42 0x00007ffff793fc66 in QQuickDeliveryAgentPrivate::deliverDragEvent(QQuickDragGrabber*, QEvent*) () at /usr/lib/libQt6Quick.so.6 #43 0x00007ffff7938a3b in QQuickDeliveryAgent::event(QEvent*) () at /usr/lib/libQt6Quick.so.6 #44 0x00007ffff78779a5 in QQuickWindow::event(QEvent*) () at /usr/lib/libQt6Quick.so.6 #45 0x00007ffff61626d8 in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /usr/lib/libQt6Core.so.6 #46 0x00007ffff6815448 in QWindowSystemInterface::handleDrop(QWindow*, QMimeData const*, QPoint const&, QFlags<Qt::DropAction>, QFlags<Qt::MouseButton>, QFlags<Qt::KeyboardModifier>) () at /usr/lib/libQt6Gui.so.6 #47 0x00007ffff1ac6960 in () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #48 0x00007ffff1a7c96b in QXcbConnection::handleXcbEvent(xcb_generic_event_t*) () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #49 0x00007ffff1a8460c in QXcbConnection::processXcbEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #50 0x00007ffff1a99987 in () at /usr/lib/qt6/plugins/platforms/../../../libQt6XcbQpa.so.6 #51 0x00007ffff4dcaf69 in () at /usr/lib/libglib-2.0.so.0 #52 0x00007ffff4e29327 in () at /usr/lib/libglib-2.0.so.0 #53 0x00007ffff4dc9162 in g_main_context_iteration () at /usr/lib/libglib-2.0.so.0 #54 0x00007ffff6397934 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt6Core.so.6 #55 0x00007ffff616cc5e in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /usr/lib/libQt6Core.so.6 #56 0x00007ffff6165178 in QCoreApplication::exec() () at /usr/lib/libQt6Core.so.6 #57 0x00005555555a6996 in main(int, char**) (argc=7, argv=0x7fffffffd6d8) at src/main.cpp:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell -Handtypos --hidden --format brief