feat: eme controller #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Urls will be available only after netlify deploy. PreviewApi Reference
Demo |
❌ Deploy Preview for videojsdev failed. Why did it fail? →
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
==========================================
+ Coverage 63.89% 63.98% +0.09%
==========================================
Files 114 115 +1
Lines 4833 4848 +15
Branches 633 635 +2
==========================================
+ Hits 3088 3102 +14
- Misses 1737 1738 +1
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| distinctiveIdentifier?: MediaKeysRequirement; | ||
| persistentState?: MediaKeysRequirement; | ||
| sessionTypes?: Array<string>; | ||
| } |
There was a problem hiding this comment.
you do not have to declare it, it should be in the built-in typescript types for browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: WIP⚠️
As of now, I am looking for discussion regarding the API/Config. Values that are commented out are things I am leabing towards EXCLUDING from the API/Config. Anything not commented is what I am expecting to include.
Please read through the comments, as I have some thoughts that I'd appreciate feedback on.
Description
Draft PR for EME controller related changes.
Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist