Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace rollup with vite for better dx and hmr for demo pages with player with worker #43

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

dzianis-dashkevich
Copy link
Collaborator

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chrome, Firefox, Safari, Edge) (if applicable)
  • Unit Tests updated or fixed (if applicable)
  • Docs/guides updated (if applicable)

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for videojsdev ready!

Name Link
🔨 Latest commit e6e39e6
🔍 Latest deploy log https://app.netlify.com/sites/videojsdev/deploys/677f104dedfbe800086462bd
😎 Deploy Preview https://deploy-preview-43--videojsdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 1.26582% with 78 lines in your changes missing coverage. Please review.

Project coverage is 61.33%. Comparing base (8ffbe91) to head (e6e39e6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ck/src/lib/pipeline-loaders/hls-pipeline-loader.ts 0.00% 67 Missing and 1 partial ⚠️
...read-with-worker/main-thread-with-worker-player.ts 0.00% 7 Missing ⚠️
...er/main-thread-with-worker/worker/worker-script.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   59.57%   61.33%   +1.75%     
==========================================
  Files         115      116       +1     
  Lines        4730     4805      +75     
  Branches      586      603      +17     
==========================================
+ Hits         2818     2947     +129     
+ Misses       1897     1847      -50     
+ Partials       15       11       -4     
Flag Coverage Δ
dash-parser 61.33% <1.26%> (+1.75%) ⬆️
env-capabilities 61.33% <1.26%> (+1.75%) ⬆️
hls-parser 61.33% <1.26%> (+1.75%) ⬆️
playback 61.33% <1.26%> (+1.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich dzianis-dashkevich merged commit e81927d into main Jan 9, 2025
8 of 10 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the hmr-vite-replace-rollup branch January 9, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant