Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mse controller #39

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Mse controller #39

merged 6 commits into from
Dec 10, 2024

Conversation

dzianis-dashkevich
Copy link
Collaborator

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • Change has been verified in an actual browser (Chrome, Firefox, Safari, Edge) (if applicable)
  • Unit Tests updated or fixed (if applicable)
  • Docs/guides updated (if applicable)

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for videojsdev ready!

Name Link
🔨 Latest commit b830bd2
🔍 Latest deploy log https://app.netlify.com/sites/videojsdev/deploys/6757c1d48ef4240008763b1c
😎 Deploy Preview https://deploy-preview-39--videojsdev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 5.60000% with 472 lines in your changes missing coverage. Please review.

Project coverage is 61.07%. Comparing base (deb8436) to head (b830bd2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/playback/src/lib/mse/mse-controller-base.ts 0.00% 208 Missing and 1 partial ⚠️
...playback/src/lib/mse/mse-controller-main-thread.ts 0.00% 78 Missing and 1 partial ⚠️
...ayback/src/lib/mse/mse-controller-worker-thread.ts 0.00% 64 Missing and 1 partial ⚠️
.../worker-thread/messages/worker-to-main-messages.ts 0.00% 63 Missing ⚠️
.../worker-thread/messages/main-to-worker-messages.ts 0.00% 31 Missing ⚠️
...back/src/lib/player/worker-thread/worker-bridge.ts 0.00% 10 Missing ⚠️
...back/src/lib/player/worker-thread/player-worker.ts 0.00% 7 Missing ⚠️
...ackages/playback/src/lib/consts/mse-buffer-type.ts 0.00% 2 Missing and 1 partial ⚠️
...kages/playback/src/lib/models/player-time-range.ts 33.33% 2 Missing ⚠️
...orker-thread/consts/worker-to-main-message-type.ts 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   65.36%   61.07%   -4.29%     
==========================================
  Files         107      115       +8     
  Lines        4276     4609     +333     
  Branches      577      586       +9     
==========================================
+ Hits         2795     2815      +20     
- Misses       1469     1778     +309     
- Partials       12       16       +4     
Flag Coverage Δ
dash-parser 61.07% <5.60%> (-4.29%) ⬇️
env-capabilities 61.07% <5.60%> (-4.29%) ⬇️
hls-parser 61.07% <5.60%> (-4.29%) ⬇️
playback 61.07% <5.60%> (-4.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich dzianis-dashkevich merged commit 0c9b14f into main Dec 10, 2024
7 of 9 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the mse-controller branch December 10, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant