-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add raw list of segment lines to manifest #145
base: main
Are you sure you want to change the base?
Conversation
Can you provide more info on why this would be useful? |
Ah, missed the link to the issue. |
I think my main concern here is that we often have memory issues in VHS and keeping around even more strings is going to exacerbate it. |
One alternative would be to feature flag this and make it default off and then if someone needs it, they can have it. I think a concrete usecase would be nice, though. |
In our case, we need to be able to change and rebuild the playlist after using the parsed playlist and it would be more efficient to do this with the raw segment lines rather than processing the whole playlist again. |
Are you using m3u8-parser directly or via VHS? |
We are using it directly. |
IIMO there could be a pluggable metod to create event data or could be via events allowing to movidy events/source as callback, kind of the data parser for custom tari. No constructor changes (imagine, next version requires new param, actual core feature, this time required, to be added or removed) |
Feature #49
Adds raw segment lines to the parsed manifest.
Playlist:
Parsed output: