Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force media capabilities check for HEVC to avoid failure on Windows #6849

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

Force media capabilities check for HEVC to decode errors from HEVC selection on Windows Firefox.

Why is this Pull Request needed?

MediaSource.isTypeSupported('') reports true, but MediaCapabilities decodingInfo tests return false and appending media results in a decode error.

Failed test results: https://github.com/video-dev/hls.js/actions/runs/11844914912/job/33012913783?pr=6845

The video playback was aborted due to a corruption problem or because the video used features your browser did not support - NS_ERROR_DOM_MEDIA_NOT_SUPPORTED_ERR (0x806e0003) - Utility MF Media Engine CDM only support for media engine playback

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Fix removeLevel side-effects when removing current level or changing index of loading level
Failed test results: https://github.com/video-dev/hls.js/actions/runs/11844914912/job/33012913783?pr=6845
@robwalch robwalch force-pushed the bugfix/firefox-windows-hevc-failure branch from 097a068 to db37e2d Compare November 16, 2024 02:07
@robwalch robwalch added this to the 1.6.0 milestone Nov 18, 2024
@robwalch robwalch merged commit 7db2f52 into master Nov 18, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/firefox-windows-hevc-failure branch November 18, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant