Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating MUI Autocomplete for searching and filtering countries #54
base: master
Are you sure you want to change the base?
Integrating MUI Autocomplete for searching and filtering countries #54
Changes from 8 commits
236c90f
eb18b50
fbfcc28
e05c24a
56815e8
81acfc9
af04460
fb5c3df
0e37967
2f6dc34
f1d1805
d0ed714
26120f2
8d7c3e6
82a6cb1
243762c
3a72910
23230e2
7ec001d
2ece262
3320608
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having all styles "hardcoded", please make them optional / customisable and provide the possibility to add custom CSS classes to each element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emkayy I think there needs to be baseline styling so that it matches the current
FlagMenu
. Do you have components of the autocomplete in mind that you'd think would benefit from making it optional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Baseline styling yes, but I think it's important to be able to customize it. Unfortunately I don't know what you mean by "Do you have components of the autocomplete in mind ...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you read the source code for
FlagsAutocomplete
there are different components in there that would require some styling. I'm asking which ones you would actually consider important to have customized styling for.It might be a good idea for you to clone my fork and see what might be important for you to have some control over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the input it would be better to have a plain input without a label that spans across the whole popper width.
However, for complete customization, the renderInput prop for Autocomplete would be great, like
<MuiTelInput flagPopupProps={{ AutocompleteProps: {renderInput: ()=> MyCustomInput }}} />
For the popper I would use the theme default style and not do any custom styling. But if you do, you should also provide props to override them.