Viashpy 0.6.0 #20
Merged
Viashpy 0.6.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSchaumont
force-pushed
the
update_ci
branch
from
78d98fa to
fdbcab8
Compare
DriesSchaumont
changed the title
rcannood
approved these changes
Jan 22, 2024
viashpy/_run.py
Outdated
Comment on lines
82
to
84
| [viash_location, "run", config, "--"] | ||
| + _add_cpu_and_memory(args, cpus, memory, "--"), | ||
| _add_cpu_and_memory([viash_location, "run", config], cpus, memory, "--") | ||
| + ["--"] | ||
| + args, |
There was a problem hiding this comment.
FYI; I think
Suggested change
| [viash_location, "run", config, "--"] | |
| + _add_cpu_and_memory(args, cpus, memory, "--"), | |
| _add_cpu_and_memory([viash_location, "run", config], cpus, memory, "--") | |
| + ["--"] | |
| + args, | |
| [viash_location, "run", config, "--"] | |
| + _add_cpu_and_memory(args, cpus, memory, "---"), |
Would also have worked.
There was a problem hiding this comment.
Also, why pass any args at all? Why not just
Suggested change
| [viash_location, "run", config, "--"] | |
| + _add_cpu_and_memory(args, cpus, memory, "--"), | |
| _add_cpu_and_memory([viash_location, "run", config], cpus, memory, "--") | |
| + ["--"] | |
| + args, | |
| [viash_location, "run", config, "--"] | |
| + _add_cpu_and_memory([], cpus, memory, "---") | |
| + args |
There was a problem hiding this comment.
Turns out I forgot that ---memory can also be used with viash run. viash run builds an executable and everything after -- gets passed to it (including ---memory and ---cpus). Good suggestion! This simplifies thing a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18