Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another minimal test for export json_schema --strict and --minimal #575

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Oct 20, 2023

Describe your changes

Add another minimal test for export json_schema --strict and --minimal

Do a rough length comparison

Issue ticket number and link

Closes #xxxx (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • Relevant unit tests have been added

@Grifs Grifs requested a review from rcannood October 20, 2023 08:04
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
.../viash/functionality/dependencies/Dependency.scala 81.25% <ø> (ø)
...h/functionality/dependencies/LocalRepository.scala 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@Grifs Grifs merged commit 88f2efa into develop Oct 23, 2023
9 checks passed
@rcannood rcannood deleted the feature/test_json_strict_minimal branch February 11, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants