Fix github uri -> repo, add local repository and local dependency exa… #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
approved these changes
Oct 13, 2023
Comment on lines
42
to
43
| """name: qc/multiqc | ||
| |repository: "github://openpipelines-bio/modules:0.3.0" | ||
| | repository: "github://openpipelines-bio/modules:0.3.0" |
There was a problem hiding this comment.
One minor question.
This indenting seems strange. I'd expect:
"""name: qc/multiqc
|repository: "github://openpipelines-bio/modules:0.3.0"
Or
""" name: qc/multiqc
| repository: "github://openpipelines-bio/modules:0.3.0"
WDYT?
There was a problem hiding this comment.
I'm not sure what went wrong but the first would be the one I expect too, aka how it was before.
There are multiple mistakes in the other examples though.
rcannood
approved these changes
Oct 13, 2023
Grifs
added a commit
that referenced
this pull request
Oct 13, 2023
#569) * Fix github uri -> repo, add local repository and local dependency example * Fix indentation in dependency examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mple
Describe your changes
Issue ticket number and link
Closes #xxxx (Replace xxxx with the GitHub issue number)
Checklist before requesting a review
I have performed a self-review of my code
Does this PR contain:
Proposed changes are described in the CHANGELOG.md
Relevant unit tests have been added