Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Busco list datasets #18

Merged
merged 7 commits into from
Feb 11, 2024
Merged

Busco list datasets #18

merged 7 commits into from
Feb 11, 2024

Conversation

dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Feb 6, 2024

Description

add component to list available busco datasets (that can be used in the busco component)

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@dorien-er
Copy link
Contributor Author

dorien-er commented Feb 6, 2024

this is a supporting component that's referred to in busco/busco, is it useful to add the help text here again, since they're already present in busco/busco?

@dorien-er dorien-er marked this pull request as ready for review February 6, 2024 16:17
@dorien-er dorien-er requested a review from rcannood February 6, 2024 16:17
@rcannood
Copy link
Contributor

rcannood commented Feb 7, 2024

this is a supporting component that's referred to in busco/busco, is it useful to add the help text here again, since they're already present in busco/busco?

One possibility is to add it to one entry but structure it a little bit, e.g.

  • Add busco:
    • busco run (#...)
    • busco list (#...)
    • busco download (#...)

WDYT?

@dorien-er
Copy link
Contributor Author

dorien-er commented Feb 9, 2024

this is a supporting component that's referred to in busco/busco, is it useful to add the help text here again, since they're already present in busco/busco?

One possibility is to add it to one entry but structure it a little bit, e.g.

  • Add busco:

    • busco run (#...)
    • busco list (#...)
    • busco download (#...)

WDYT?

Sounds good... But what about the help.txt file - doesn't seem useful to have that same file in all 3 subcomponents, shall I just leave it under the main component only?

CHANGELOG.md Outdated Show resolved Hide resolved
@rcannood rcannood merged commit 4c50ac9 into main Feb 11, 2024
8 checks passed
@rcannood rcannood deleted the busco_list_datasets branch February 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants