Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lofreq #17

Merged
merged 21 commits into from
Feb 15, 2024
Merged

Add lofreq #17

merged 21 commits into from
Feb 15, 2024

Conversation

KaiWaldrant
Copy link
Member

@KaiWaldrant KaiWaldrant commented Feb 6, 2024

Description

Add lofreq biobase components:

  • call
  • indelqual

Issue ticket number

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

viash ns test --parallel -q lofreq
The working directory for the namespace tests is /tmp/viash_ns_test3438401139745231693
           namespace        functionality             platform            test_name exit_code duration               result
              lofreq     lofreq_indelqual               docker                start                                        
              lofreq          lofreq_call               docker                start                                        
              lofreq          lofreq_call               docker     build_executable         0        2              SUCCESS
              lofreq          lofreq_call               docker              test.sh         0        1              SUCCESS
              lofreq     lofreq_indelqual               docker     build_executable         0        2              SUCCESS
              lofreq     lofreq_indelqual               docker              test.sh         0        2              SUCCESS
Not all configs built and tested successfully
  6 configs were disabled
  4/4 configs built and tested successfully
  • Check the correct box. Does this PR contain:
    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@KaiWaldrant KaiWaldrant marked this pull request as ready for review February 8, 2024 10:51
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! See comments ☺️

src/lofreq/call/config.vsh.yaml Outdated Show resolved Hide resolved
src/lofreq/call/config.vsh.yaml Outdated Show resolved Hide resolved
src/lofreq/call/config.vsh.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How big is this file? Do you think we could find a smaller one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

about 50 MB :s

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21 is the smallest chromosome. Don't really think it is inside this scope but maybe we could subset the files in the future ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confortable yet adding a 50MB resource file to the repo 😅

@KaiWaldrant KaiWaldrant requested a review from rcannood February 12, 2024 21:51
@rcannood rcannood merged commit 5a1601f into main Feb 15, 2024
7 checks passed
@rcannood rcannood deleted the add_lofreq branch February 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants