Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bgzip #13

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Add bgzip #13

merged 10 commits into from
Jan 30, 2024

Conversation

Grifs
Copy link
Contributor

@Grifs Grifs commented Jan 30, 2024

Description

Add bgzip

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@Grifs Grifs requested a review from rcannood January 30, 2024 15:23
src/bgzip/config.vsh.yaml Outdated Show resolved Hide resolved
Co-authored-by: Robrecht Cannoodt <[email protected]>
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- for real this time!

@rcannood rcannood merged commit c26a7d0 into main Jan 30, 2024
6 checks passed
@rcannood rcannood deleted the add_bgzip branch January 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants