Fixes 4108: Remove org.apache.commons.collections* imports #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @throws IllegalArgumentException thrown if object is not recognized | ||
| * @since 3.1 | ||
| */ | ||
| public static int size(final Object object) { |
There was a problem hiding this comment.
remove and use collection.size or map.size
| * @return the number of elements contained in the iterator | ||
| * @since 4.1 | ||
| */ | ||
| public static int sizeIterator(final Iterator<?> iterator) { |
There was a problem hiding this comment.
we can remove this as well
| * @param iterable the iterable to check, may be null | ||
| * @return the number of elements contained in the iterable | ||
| */ | ||
| public static int sizeIterable(final Iterable<?> iterable) { |
There was a problem hiding this comment.
we can remove this as well
| import java.util.Iterator; | ||
| import java.util.Map; | ||
|
|
||
| public class ExtendedCollectionUtils { |
There was a problem hiding this comment.
maybe this class is not needed anymore since java 17 auto cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/4108commons-collections4from main and xls gradlesorg.apache.commons.collections*imports and replaced with ad-hoc newly-created utils functions