Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/users migrations #339

Merged
merged 10 commits into from
Nov 24, 2024
Merged

Chore/users migrations #339

merged 10 commits into from
Nov 24, 2024

Conversation

JohanHjelsethStorstad
Copy link
Member

DOBBEL OMEGA
This PR adds user migrations.

@Paulijuz
Copy link
Member

Paulijuz commented Nov 8, 2024

Took a quick look now and it looks good. I'll do a proper review once #328 is merged and the conflicts are fixed.

@JohanHjelsethStorstad
Copy link
Member Author

@Paulijuz. - now rebased on main

@theodorklauritzen theodorklauritzen self-requested a review November 24, 2024 09:56
Copy link
Member

@theodorklauritzen theodorklauritzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

It's probably nice to store if users are archived. However I don't think it's necessary to archive users. I think they still should be able to login, but with limited permissions

@JohanHjelsethStorstad JohanHjelsethStorstad merged commit 9625bbe into main Nov 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants