Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/event tags #337

Merged
merged 26 commits into from
Oct 12, 2024
Merged

Feat/event tags #337

merged 26 commits into from
Oct 12, 2024

Conversation

JohanHjelsethStorstad
Copy link
Member

This PR implements event-tags. This also includes som new infrastructure:

  • The new Action and ActionNoData hof
  • A way to do QueryParams (server-side) in a declarative way

@JohanHjelsethStorstad
chore: adds method to create a event tag
267b419
@JohanHjelsethStorstad
chore: adds support for color in event-tag schema
d56663f
@JohanHjelsethStorstad
chore: adds a basic Eventtag component
0e9072c
@JohanHjelsethStorstad
feat: creating event tags now works
4a01b3a
@JohanHjelsethStorstad
feat: adds readEventTag actions and Action hof
ab73164
@JohanHjelsethStorstad
feat: display all available tags to user
3c24ec5
@JohanHjelsethStorstad
chore: shows create and update tag options only for eligable users
e0f1bd6
@JohanHjelsethStorstad
fix: must distinguish Session class and object better to be able to r…
876e659 
…eturn Session from a action
@JohanHjelsethStorstad
style: linter
a55fddf
@JohanHjelsethStorstad
chore: fixes minor isssues
557ec38
@JohanHjelsethStorstad
chore: better layout in EventTagsAdmin
4c39710
@JohanHjelsethStorstad
chore: adds basic suport for query params
9b0dad1
@JohanHjelsethStorstad
chore: makes the way to work with QueryPrams good
a08c0b1
@JohanHjelsethStorstad
fix: fault in data-validation for getting data into dynamicFields for…
46dd719 
… auther function
@JohanHjelsethStorstad
chore: displays the selected tag to the user
d439faa
@JohanHjelsethStorstad
chore: updates screen schema to reflect new event feats
550d907
@JohanHjelsethStorstad
chore: adds ability to add tags to events
99ae4b6
@JohanHjelsethStorstad
chore: improves user experience when selecting tags
6dbd2db
@JohanHjelsethStorstad
fix: skipDuplicates when creating EventTagEvents on update
d8f9286
@JohanHjelsethStorstad
feat: displays an events tags to the end user
54e47d7
@JohanHjelsethStorstad
chore: adds ability to remove tags in search
5b5569e
@JohanHjelsethStorstad
chore: makes it easy for a user to select more tags
2da145d
@JohanHjelsethStorstad
feat: adds tags functionality to event-archive page
a68d711
@JohanHjelsethStorstad
feat: destroy event tags
bd7c130
@JohanHjelsethStorstad
style: lint errors
20b5dda
@Paulijuz
Copy link
Member

Paulijuz commented Oct 12, 2024 •
edited
Loading

bilde
The tag edit menu overflows the bottom of the screen. This means that I cannot see the error message for why I can't delete a tag.

Paulijuz
Paulijuz previously approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Paulijuz Paulijuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few minor issues which can be fixed at a later date as always.

src/actions/events/create.ts Show resolved Hide resolved
src/lib/query-params/QueryParam.ts Outdated Show resolved Hide resolved
Paulijuz
Paulijuz approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Paulijuz Paulijuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

@JohanHjelsethStorstad JohanHjelsethStorstad merged commit 7f7159b into main Oct 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paulijuz Paulijuz Paulijuz approved these changes

@theodorklauritzen theodorklauritzen Awaiting requested review from theodorklauritzen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohanHjelsethStorstad @Paulijuz