Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/npm audit october 2024 #335

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

JohanHjelsethStorstad
Copy link
Member

This PR

  • Upgrades to node 22
  • Fixes the most critical package vulnerabilities.

We have had problems changing react-pdf version because of a missing pdfs-worker. I have now found one that works. It does depend on using Promise.withResolvers - a new method. This has two consequences:

  • We should upgrade to node 22 (so the method is available server-side)
  • Some older browsers might have a problem - I have created a fallback.

@JohanHjelsethStorstad
Copy link
Member Author

node 22 will become LTS in late October so I see no problem in upgrading

@JohanHjelsethStorstad JohanHjelsethStorstad force-pushed the chore/npm-audit-october-2024 branch from d7dc954 to 25e28d8 Compare October 7, 2024 16:15
@JohanHjelsethStorstad
Copy link
Member Author

JohanHjelsethStorstad commented Oct 7, 2024

For some reason I had to explicitly type two things in VevenAdapter too @theodorklauritzen

Copy link
Member

@Paulijuz Paulijuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine at least. Can i use says that withResolvers has about 84% global coverage so I'd say it's good to go.

Did you format the prisma files by mistake by the way? lol

@JohanHjelsethStorstad
Copy link
Member Author

I think it might have happened when reinstalling on node 22

@JohanHjelsethStorstad JohanHjelsethStorstad merged commit 00f8146 into main Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants