-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GE refactor #1748
GE refactor #1748
Conversation
I know this is still [WIP], but I notice that selected data gets cleared when you go back - is that desirable behaviour? Like if you select "veteran" and proceed forward, when you navigate back using the in-app back button that selection persists, but if you use the browser back it gets cleared. |
@brdunfield It looks like that is happening because I'm not immediately putting the user's selection into the url query parameters. It gets put into the url when you visit the next page. So when you click browser back, it goes back to a url that doesn't include the query param, and then that clears it from redux. I tried changing the behaviour to be more like it was before, but it started introduced a lot of complexity to the code. So my preference would be to leave it like this until we get feedback from user testing that it's an issue. If someone hits browser back they probably wanted to re-answer the question anyway. |
Tests are passing but getting a few failed propTypes for fontSize on AnchorLink in the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🦑 Nice work!
Working on #1733, this should also make #1478 easier
This is my attempt at a massive refactor of the guided experience with the goal of making it simpler by turning each question into its own page. What do you think - is this simpler?