Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render a <button> if useLink is not present. #1391

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Render a <button> if useLink is not present. #1391

merged 1 commit into from
Nov 5, 2018

Conversation

brdunfield
Copy link
Collaborator

Add useLink to HeaderButtons in the benefit cards that are actually links.

Resolves #1388 but not #1390 - one step along this process.

Render a button if useLink is not present. Add useLink to HeaderButto…
8111381 
…ns in the benefit cards that are actually links
sastels
sastels approved these changes Nov 5, 2018
View reviewed changes
Copy link
Collaborator

@sastels sastels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🦑

@brdunfield brdunfield merged commit 7e4d9d1 into master Nov 5, 2018
@brdunfield brdunfield deleted the HeaderButton-split branch November 5, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastels sastels sastels approved these changes

@leonL leonL Awaiting requested review from leonL

@smcmurtry smcmurtry Awaiting requested review from smcmurtry

@SupeDeDupe SupeDeDupe Awaiting requested review from SupeDeDupe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brdunfield @sastels