Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logstash-plugins] output: added options to remove metadata fields #33059

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

radu-gheorghe
Copy link
Contributor

…from documents after using them for put/update.

The default assumption is that if we want the ID from the document, we assume we store the whole document (including the ID). But if we don't want the ID in the document, we can't remove it like we do with e.g. @timestamp (using the mutate filter, as in the README example), because we wouldn't have it at index time. The option I see now is to delete the ID from the document as a new option of the output plugin.

Similarly, we have new options for namespace, document type and operation, in case we want them to be dynamic (i.e. from document fields).

With this PR there's also a critical bugfix: explicit id_field didn't work. It would work with the default id from the document and it did generate UUIDs, but we have explicit id_field in the README even :)

…om documents after using them for put/update
Copy link
Member

@kkraune kkraune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kkraune kkraune merged commit 323c114 into master Dec 28, 2024
3 checks passed
@kkraune kkraune deleted the logstash-output-remove-metadata-fields branch December 28, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants