Handle parsing errors in semantic rules better #33052
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw IllegalArgumentException when there are parse errors in semantic rules, this will return an invalid application package error to the user with appropriate message instead of internal server error as it is today. IllegalArgumentException will be translated to 400 Bad Request in repsonse from config server.
bratseth
approved these changes
Dec 19, 2024
hmusum
deleted the
hmusum/handle-parse-excaption-in-semantic-rules-better
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw IllegalArgumentException when there are parse errors in semantic rules, this will return an invalid application package error to the user with appropriate message instead of internal server error as it is today.
IllegalArgumentException will be translated to 400 Bad Request in repsonse from config server.