Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc link to warning when there are fieldset inconsistencies #33041

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

hmusum
Copy link
Member

@hmusum hmusum commented Dec 16, 2024

@radu-gheorghe please review.

Adding just link to doc for now. I see some unexpected behavior when trying to show warning for all fields in a schema, so will follow up that in another PR.

@hmusum hmusum force-pushed the hmusum/add-doc-link-when-field-settings-dont-match branch from 0382586 to d87c369 Compare December 16, 2024 14:04
@hmusum hmusum changed the title Add doc link to warning when there are fieldset inconstencies Add doc link to warning when there are fieldset inconsistencies Dec 17, 2024
Copy link
Contributor

@radu-gheorghe radu-gheorghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for doing this!

@hmusum hmusum merged commit 0d9e9ae into master Dec 17, 2024
3 checks passed
@hmusum hmusum deleted the hmusum/add-doc-link-when-field-settings-dont-match branch December 17, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants