Support tensor field presence checks as part of document selection evaluation #32993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a sentinel `TensorValue` selection-internal type which is instantiated iff a field is a tensor, and which only has true/false semantics when compared against (explicit or implicit) `null` values. All other comparisons poison the expression with `Invalid` results.
Also enforce that comparing with anything but `null` for tensor field values returns `Invalid`.
Supports both attribute and non-attribute tensors.
toregge
approved these changes
Dec 5, 2024
vekterli
deleted the
vekterli/support-tensor-field-presence-in-doc-sel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@geirst @toregge please review. Can be reviewed per commit, if desired.
For the C++ implementation, adds a sentinel
TensorValueselection-internal type which is instantiated iff a field is a tensor, and which only allows for comparing against (explicit or implicit)nullvalues. All other comparisons poison the expression withInvalidresults. In other words, tensor contents cannot be inspected as part of selection evaluation.This sentinel is also instantiated by the search core tensor attribute wiring.
The Java implementation has very different evaluation semantics, so the changes are mostly about enforcing
Invalidresults when using tensors in ways that are not supported.Also doing some casual code cleanup.