Reduce number of lookups in LRU map for updates and invalidations #32951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havardpe
approved these changes
Nov 27, 2024
* Add `find_no_ref` method to `lrucache_map` which returns an iterator to the mapped element iff it exists, and which does _not_ update the LRU ordering. * Collapse 3 LRU map lookups into 1 for cache updates and invalidations for existing mappings. * Rewrite `lrucache_map` tests to use GTest
vekterli
force-pushed
the
vekterli/reduce-cache-lru-lookups
branch
from
b7a338e to
239bc8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@havardpe please review. The fun never ends 👹
find_no_refmethod tolrucache_mapwhich returns an iterator to the mapped element iff it exists, and which does not update the LRU ordering.lrucache_maptests to use GTest