Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): improve cloudsmith artifact deletion script logging #32942

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(CI): improve cloudsmith artifact deletion script logging #32942

merged 1 commit into from
Nov 25, 2024

Conversation

esolitos
Copy link
Contributor

@esolitos esolitos commented Nov 25, 2024 •
edited
Loading

What

  • add error handling to continue on failure
  • improve log messages to better track progress

Why

  • do not halt the cleanup for a single package deletion error (happens quite frequently)
  • Improve clarity of deletion log

@esolitos @gitbutler-client
fix: improve artifact deletion script logging
873137e 
Improve clarity of deletion log by adjusting message format and adding RPMID details to output. Add error handling to continue on failure.
@esolitos esolitos merged commit a6dc46b into master Nov 25, 2024
4 checks passed
@esolitos esolitos deleted the marlon/log-rpm-deletion-process branch November 25, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freva freva freva approved these changes

@glebashnik glebashnik Awaiting requested review from glebashnik

@geirst geirst Awaiting requested review from geirst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esolitos @freva