Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the --file option to "vespa query" #32843

Merged
merged 3 commits into from
Nov 13, 2024
Merged

add the --file option to "vespa query" #32843

merged 3 commits into from
Nov 13, 2024

Conversation

arnej27959
Copy link
Member

@mpolden please review
@kkraune FYI

mpolden
mpolden reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@mpolden mpolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a test, ideally one where all parameters come from a file and one with a combination of file+arguments.

client/go/internal/cli/cmd/query.go Outdated Show resolved Hide resolved
client/go/internal/cli/cmd/query.go Outdated Show resolved Hide resolved
client/go/internal/cli/cmd/query.go Show resolved Hide resolved
@arnej27959
udpates after review:
1edbc89 
* rename "--postFile" to just "--file"
* add unit tests for "--file"
* reword help description
@arnej27959
refactor option arguments into a struct type
e207edd
mpolden
mpolden approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@mpolden mpolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@arnej27959 arnej27959 merged commit ece9a08 into master Nov 13, 2024
6 checks passed
@arnej27959 arnej27959 deleted the arnej/add-query-postfile branch November 13, 2024 12:01
@arnej27959 arnej27959 changed the title add the --postFile option to "vespa query" add the --file option to "vespa query" Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpolden mpolden mpolden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnej27959 @mpolden