Glebashnik/feed field generator #32842
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratseth
reviewed
Nov 13, 2024
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
...glanguage/src/main/java/com/yahoo/vespa/indexinglanguage/expressions/GenerateExpression.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,29 @@ | |||
| package ai.vespa.generative; | |||
There was a problem hiding this comment.
Same, I think we could put this in llm.generation
And maybe, since what separates it from Generator isn't that it's generating from a language model, but that it's taking an additional config specifying a prompt, we could call it something like PromptedGenerator, or ConfiguredGenerator?
linguistics/src/main/java/com/yahoo/language/process/Generator.java
Outdated
Show resolved
Hide resolved
linguistics/src/main/java/com/yahoo/language/process/Generator.java
Outdated
Show resolved
Hide resolved
| @@ -31,7 +34,7 @@ | |||
| * | |||
| * @author lesters | |||
| */ | |||
| public class LocalLLM extends AbstractComponent implements LanguageModel { | |||
| public class LocalLLM extends AbstractComponent implements LanguageModel, Generator { | |||
There was a problem hiding this comment.
The role of Generator is to apply a LanguageModel to a generation task specified by a context. This is a more general API so it's a bit messy for it to know about that context (and also to call itself through a utility defined elsewhere). I see the purpose though ... maybe there's a better solution, but I need to get some breakfast now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.