Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "vespa auth show" command #32834

Merged
merged 3 commits into from
Nov 12, 2024
Merged

add "vespa auth show" command #32834

merged 3 commits into from
Nov 12, 2024

Conversation

arnej27959
Copy link
Member

@mpolden please review

mpolden
mpolden previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mpolden mpolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a test would be nice. I think it can be simple as api_key_test.go + mocking of the user V1 response.

mpolden
mpolden previously approved these changes Nov 12, 2024
View reviewed changes
@arnej27959 arnej27959 merged commit d1838e6 into master Nov 12, 2024
6 checks passed
@arnej27959 arnej27959 deleted the arnej/add-auth-show branch November 12, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpolden mpolden mpolden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnej27959 @mpolden